[AssetMapper] Allowing circular references in JavaScriptImportPathCompiler #52323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ec9e073 to
2f98cb3
Compare
fabpot
approved these changes
Oct 28, 2023
|
Thank you @weaverryan. |
2f98cb3 to
b0953a4
Compare
xabbuh
added a commit
that referenced
this pull request
Oct 29, 2023
This PR was merged into the 6.4 branch. Discussion ---------- [AssetMapper] Fixing merge | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | None | License | MIT Fixing the merge of #52323, #52331 and #52349 Also tested on a real project locally to verify the moving pieces :). Thanks! Commits ------- 99d5cbb [AssetMapper] Fixing merge from multiple PR's
This was referenced Oct 29, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
In AssetMapper, we throw a
CircularAssetsExceptionif you ask for theapp.jsasset, but it's still being created. This circular situation only happens via asset compilers: if, while compilingapp.js, we ask forother.js... and then while compiling that, we ask forapp.js.However, JS modules do allow for circular references - e.g.
app.jsimportsother.jswhich importsapp.js. Before this PR, this situation would trigger theCircularAssetsException. After, it is handled correctly.JavaScriptImportPathCompilercalls$assetMapper->getAsset()only to populate theMappedAsset.javaScriptImportsproperty. So, allowing for the half-createdMappedAssetis safe here: we do not use any of the not-yet-populated properties.Cheers!