[AssetMapper] Fixing bug where JSCompiler used non-absolute importmap entry path #52368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
489c790 to
31d04ef
Compare
|
Thank you @weaverryan. |
This was referenced Nov 10, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced over the weekend in #52349.
The
pathkey insideimportmap.phpcan be a full filesystem path or it can start with./to indicate a relative path to the root directory. That has been the case for weeks. In #52349, when start using thepathof an importmap entry to find theMappedAsset. When doing that, I didn't consider the case wherepathis a relative path.This PR fixes that and moves the code handling this into
ImportMapConfigReaderso that we're not repeating it in several places.Cheers!