DX: re-apply PHP CS Fixer, partially #52398
Conversation
| @@ -128,7 +128,7 @@ public static function hexToDateTime(string $time): \DateTimeImmutable | |||
|
|
|||
| if (self::TIME_OFFSET_BIN <= $time) { | |||
| $time = self::add($time, self::TIME_OFFSET_COM2); | |||
| $time[0] = $time[0] & "\x7F"; | |||
| $time[0] &= "\x7F"; | |||
There was a problem hiding this comment.
AFAIK, this is not the same for string indexes. Would need double checking if this was fixed in recent versions of PHP.
There was a problem hiding this comment.
What is the string index here? (not the [0], right?)
It is causing CI to fail, let's revert for now indeed
There was a problem hiding this comment.
yes it is, same for the other similar changes in the PR
There was a problem hiding this comment.
this is not the same for string indexes.
can you elaborate on that string index a bit? I'm not aware what is the underlying issue here.
same for the other similar changes in the PR
after revert ot &= , CI is green (ok, except of fabbot for file license-headers)
There was a problem hiding this comment.
Sure: https://3v4l.org/GI1NW
There was a problem hiding this comment.
Rule marked as risky, at least: PHP-CS-Fixer/PHP-CS-Fixer#7418
perhaps, with time we can have better detection if we touch index or not
e05a31c to
110d13b
Compare
|
Thank you @keradus. |
One further step to clean the CS status-quo, aiming for all-green in long-term.
~90 files remaining, yet they may require some further update on tool itself
best to review commit by commit