Skip to content

[Mailer] relax constraints to also run tests with symfony/webhook 6.3 #52404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 1, 2023
Merged

[Mailer] relax constraints to also run tests with symfony/webhook 6.3 #52404

merged 1 commit into from
Nov 1, 2023

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Nov 1, 2023

Q A
Branch? 6.4
Bug fix? no
New feature? no
Deprecations? no
Issues
License MIT

@carsonbot carsonbot added this to the 6.4 milestone Nov 1, 2023
@xabbuh
Copy link
Member Author

xabbuh commented Nov 1, 2023

alternative solution: change the constraint in require-dev to ^6.3|^7.0 (as it's done in the Mailgun, Postmark and Sendgrid bridges)

@nicolas-grekas
Copy link
Member

if there is a solution that doesn't involve conflict that's better indeed.

@xabbuh xabbuh changed the title [Mailer] do not allow symfony/webhook 6.3 [Mailer] relax constraints to also run tests with symfony/webhook 6.3 Nov 1, 2023
@xabbuh
Copy link
Member Author

xabbuh commented Nov 1, 2023

I updated the constraints in the require-dev section instead

@nicolas-grekas
Copy link
Member

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit 6c3d377 into symfony:6.4 Nov 1, 2023
@xabbuh xabbuh deleted the pr-50502-51264 branch November 1, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Mailer Status: Needs Review
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
3 participants
@xabbuh @nicolas-grekas @carsonbot