[HttpClient] add native argument for the test server working directory #52418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Nov 2, 2023
| Q | A |
|---|---|
| Branch? | 7.0 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Issues | |
| License | MIT |
GromNaN
approved these changes
Nov 2, 2023
| * @param string|null $workingDirectory | ||
| */ | ||
| public static function start(int $port = 8057/* , string $workingDirectory = null */): Process | ||
| public static function start(int $port = 8057, string $workingDirectory = __DIR__.'/Fixtures/web'): Process |
There was a problem hiding this comment.
I think we should still accept null and have it be the default
There was a problem hiding this comment.
I have pushed an update. Is that what you had in mind?
|
Thank you @xabbuh. |
nicolas-grekas
added a commit
to nicolas-grekas/symfony
that referenced
this pull request
Nov 15, 2023
fabpot
added a commit
that referenced
this pull request
Nov 15, 2023
…r the test server working directory" (nicolas-grekas) This PR was merged into the 7.0 branch. Discussion ---------- [HttpClient] Revert "minor #52418 add native argument for the test server working directory" | Q | A | ------------- | --- | Branch? | 7.0 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT This reverts commit fa590af, reversing changes made to 907b683. I completly forgot that we don't want to release a new major for contracts so the code in 7.0 must be in sync with the one in 6.4. /cc `@xabbuh` Commits ------- 1b61e92 Revert "minor #52418 [HttpClient] add native argument for the test server working directory (xabbuh)"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.