[HttpKernel] the debug log processor must be a callable #52426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Symfony/Component/HttpKernel/Log/DebugLoggerConfigurator.php
Outdated
Show resolved
Hide resolved
6987632 to
81baf53
Compare
stof
requested changes
Nov 2, 2023
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Compiler/AddDebugLogProcessorPass.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/HttpKernel/Log/DebugLoggerConfigurator.php
Outdated
Show resolved
Hide resolved
|
re-reading the existing code I have updated this PR to only enforce the processor to be a callable and reverted the other changes |
stof
approved these changes
Nov 7, 2023
|
|
||
| public function __construct(DebugLoggerInterface $processor, bool $enable = null) | ||
| public function __construct(callable $processor, bool $enable = null) |
There was a problem hiding this comment.
should be ProcessorInterface|callable for monolog 3, isn't it?
There was a problem hiding this comment.
We could change it that way, but it's not needed IMO as the ProcessorInterface does nothing more than enforcing the __invoke() method to be present: https://github.com/Seldaek/monolog/blob/main/src/Monolog/Processor/ProcessorInterface.php#L26
|
Thank you @xabbuh. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 9, 2023
This PR was merged into the 6.4 branch. Discussion ---------- [HttpKernel] Fix DebugLoggerConfigurator | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT Issue introduced in #52426: by turning the callable into a closure, we broke the `instanceof` check later in the class. Commits ------- 33721f5 [HttpKernel] Fix DebugLoggerConfigurator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Monolog processor must be a callable, but a
DebugLoggerInterfaceimplementation is not necessarily a callable.