[TwigBridge] Mark CodeExtension as @internal #52449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Nov 4, 2023
|
Does marking this class For instance |
This was referenced Nov 10, 2023
Merged
Merged
fabpot
added a commit
that referenced
this pull request
Nov 18, 2023
…nicolas-grekas) This PR was merged into the 7.0 branch. Discussion ---------- [WebProfilerBundle] Mark CodeExtension as non-internal | Q | A | ------------- | --- | Branch? | 7.0 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT From #52449 (comment) by `@GromNaN` Using those twig helpers in a profiler page is 100% legit. I think that the notice in the class' docbloc + the fact it moved to the WebProfilerBundle namespace allows us to mark the class back as non-internal. Commits ------- b1c437a [WebProfilerBundle] Mark CodeExtension as non-internal
symfony-splitter
pushed a commit
to symfony/web-profiler-bundle
that referenced
this pull request
Nov 18, 2023
…nicolas-grekas) This PR was merged into the 7.0 branch. Discussion ---------- [WebProfilerBundle] Mark CodeExtension as non-internal | Q | A | ------------- | --- | Branch? | 7.0 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT From symfony/symfony#52449 (comment) by `@GromNaN` Using those twig helpers in a profiler page is 100% legit. I think that the notice in the class' docbloc + the fact it moved to the WebProfilerBundle namespace allows us to mark the class back as non-internal. Commits ------- b1c437a759a [WebProfilerBundle] Mark CodeExtension as non-internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is really just internal code used by our own tools. Let's make it clear that nobody should use it in production.