[Translation] add bundles trans paths into commands (extract/pull/push) #52454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4d47db0 to
8f49c64
Compare
OskarStark
reviewed
Nov 4, 2023
src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTestCase.php
Outdated
Show resolved
Hide resolved
…rameworkExtensionTestCase.php Co-authored-by: Oskar Stark <oskarstark@googlemail.com>
|
Thanks @Jibbarth for your contribution. I think we should consider this as a feature, and it should be enabled under a configuration option. I understand your use case, but I'm not sure everyone needs to extract all messages from all bundles in their app. Could you add an option in translation configuration? |
|
@welcoMattic thanks for the review 🤗 okay I'll give it a try. Any idea of configuration name that could be added ? |
2 tasks
|
Implemented in #52456 as a feature |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello !
While playing with
translation:extractcommand to trying to gather all sylius translation in one file in order to send them to a translation provider, I found that although translation file are correctly loaded from a bundle while browsing the application, it was mandatory to launch thetranslation:extractfor EACH bundle, and in a Sylius App, there is a lot 😅This fix pass all $transPaths discovered during compilation into that command (and also push/pull commands).
In my mind, it's a bugfix, that's why I targetted 5.4, but could be considered as new feature, I'm not sure.