Skip to content

[HttpKernel] Fix quotes expectations in tests #52473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

alexandre-daubois
Copy link
Member

Q A
Branch? 6.3
Bug fix? yes
New feature? no
Deprecations? no
Issues -
License MIT

Following #52472 (comment)

On Windows, quotes are only added when necessary. This means that for a value like foobar, no quotes are added. I updated the test so the first dataset shows the escaping whereas the second updated dataset shows that it is expected that no quotes are added around data.

@nicolas-grekas
Copy link
Member

/cc @MatTheCat

@nicolas-grekas
Copy link
Member

Thank you @alexandre-daubois.

@nicolas-grekas nicolas-grekas merged commit c752607 into symfony:6.3 Nov 7, 2023
@alexandre-daubois alexandre-daubois deleted the fix-quotes-tests branch November 7, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants