Skip to content

[Messenger] Improve PHPDoc descriptions of attribute classes and properties #52475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

makmaoui
Copy link
Contributor

@makmaoui makmaoui commented Nov 6, 2023

Q A
Branch? 6.4
Bug fix? no
New feature? yes
Deprecations? no
Issues Part of #51920
License MIT

Add PHPDoc to Messenger attribute : AsMessageHandler

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot carsonbot changed the title [messenger] Improve PHPDoc descriptions of attribute classes and properties [Messenger] Improve PHPDoc descriptions of attribute classes and properties Nov 6, 2023
@makmaoui makmaoui force-pushed the improve-attributes-php-doc-messenger branch from 2d756af to bd8b58b Compare November 6, 2023 22:12
@makmaoui makmaoui force-pushed the improve-attributes-php-doc-messenger branch from bd8b58b to a48bac1 Compare November 7, 2023 20:25
@nicolas-grekas nicolas-grekas modified the milestones: 6.4, 7.1 Nov 15, 2023
@fabpot
Copy link
Member

fabpot commented Dec 4, 2023

Thank you @makmaoui.

@fabpot fabpot merged commit 11f09e0 into symfony:7.1 Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants