Skip to content

Move CodeExtension from TwigBridge to WebProfilerBundle #52483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Nov 7, 2023

Q A
Branch? 7.0
Bug fix? no
New feature? no
Deprecations? no
Issues -
License MIT

The class is internal in 7.0 so we can move it closer to where it's used.

@carsonbot carsonbot added this to the 7.0 milestone Nov 7, 2023
@nicolas-grekas nicolas-grekas added the ❄️ Feature Freeze Important Pull Requests to finish before the next Symfony "feature freeze" label Nov 7, 2023
@stof
Copy link
Member

stof commented Nov 7, 2023

this requires making sure that WebProfilerBundle 6.4 conflicts with TwigBundle 7.0 and TwigBridge 7.0

nicolas-grekas added a commit that referenced this pull request Nov 7, 2023
…nicolas-grekas)

This PR was merged into the 6.4 branch.

Discussion
----------

[TwigBundle][WebProfilerBundle] Add conflicts with 7.0

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

Preparing for #52483

Commits
-------

ad1848c [WebProfilerBundle][TwigBundle] Add conflicts with 7.0
@nicolas-grekas nicolas-grekas merged commit dcc2178 into symfony:7.0 Nov 7, 2023
@nicolas-grekas nicolas-grekas deleted the wpb-code-ext branch November 9, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❄️ Feature Freeze Important Pull Requests to finish before the next Symfony "feature freeze" Status: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants