Skip to content

[VarDumper] Accept mixed key on DsPairStub #52496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

marc-mabe
Copy link
Contributor

@marc-mabe marc-mabe commented Nov 8, 2023

Q A
Branch? 6.3
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #52495
License MIT

Db\Map accepts any types as key

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@marc-mabe marc-mabe changed the base branch from 6.4 to 6.3 November 8, 2023 10:37
`Db\Map` accepts any types as key
@carsonbot carsonbot changed the title Accept mixed key on DsPairStub [VarDumper] Accept mixed key on DsPairStub Nov 8, 2023
@symfony symfony deleted a comment from carsonbot Nov 8, 2023
@OskarStark OskarStark modified the milestones: 6.4, 6.3 Nov 8, 2023
@OskarStark OskarStark changed the title [VarDumper] Accept mixed key on DsPairStub [VarDumper] Accept mixed key on DsPairStub Nov 8, 2023
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a testcase?

@nicolas-grekas
Copy link
Member

Thank you @marc-mabe.

@nicolas-grekas nicolas-grekas merged commit 3922e80 into symfony:6.3 Nov 9, 2023
@marc-mabe marc-mabe deleted the patch-1 branch November 10, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[VarDumper] Ds\Map handles object keys
4 participants