Skip to content

do not emit an error if an issue suppression handler was not used #52507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2023
Merged

do not emit an error if an issue suppression handler was not used #52507

merged 1 commit into from
Nov 9, 2023

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Nov 9, 2023

Q A
Branch? 5.4
Bug fix? no
New feature? no
Deprecations? no
Issues
License MIT

@carsonbot carsonbot added this to the 5.4 milestone Nov 9, 2023
@xabbuh
Copy link
Member Author

xabbuh commented Nov 9, 2023

see https://psalm.dev/docs/running_psalm/configuration/#findunusedissuehandlersuppression and vimeo/psalm#10341

@nicolas-grekas
Copy link
Member

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit d3afe42 into symfony:5.4 Nov 9, 2023
@xabbuh xabbuh deleted the psalm branch November 9, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@xabbuh @nicolas-grekas @carsonbot