Actually, if the import has side effects, this is a valid usage.

I think in this case the side effect is to add the plugin to the global jquery object.

Actually, if the import has side effects, this is a valid usage.

You're right. I guess i'm pleading into the void: "Can we please stop causing side effects with modules!!!" :)

I'm no expert, but I also think the idea of explicitly adding the plugin to jquery is better than automatically adding it, even though it's an additional line of code. Because modules don't allow for conditional imports, I don't see how it's possible to selectively add theme-specific plugins.

That is, if there's are select-bs4, select-bs5 and select-tailwind plugins, and merely importing them adds the plugin to jquery, there's no way to say "no, just bs5".

Better, I think would be

import selectBs5 from 'select-bs5';
import selectBs4 from 'select-bs4';
let plugin =  (theme=='bs4') ? selectBs4 : selectBs5;
$.addPlugin(plugin);

Allan is working on version 2 of datatables, as importmaps and javascript modules become more prominent perhaps he'll allow something like that.

@tacman that's something to discuss elsewhere. AssetMapper has to handle JS files as they exist.

Yes, it's working now, the datatables modules are working. And fontawesome is working when I add those lines, I'm not sure if there's supposed to be a way to simply import.