[AssetMapper] avoid caching MappedAsset inside JavaScript Import #52523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Symfony/Component/AssetMapper/ImportMap/ImportMapGenerator.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/AssetMapper/ImportMap/ImportMapGenerator.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/AssetMapper/ImportMap/JavaScriptImport.php
Outdated
Show resolved
Hide resolved
c6009ce to
caf7fcb
Compare
The problem is that these could get out of date, allowing asset Foo to have a JavaScript import for the MappedAsset for Bar, but it is out of date because Bar has since changed.
caf7fcb to
bb5ef88
Compare
This was referenced Nov 10, 2023
Merged
Merged
xabbuh
added a commit
that referenced
this pull request
Nov 24, 2023
This PR was merged into the 6.4 branch. Discussion ---------- [AssetMapper] Fix windows ci fail | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fixes CI | License | MIT I missed the windows-only test in #52523. Cheers! Commits ------- e172b68 [AssetMapper] Fixing out-of-date test on Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Subtle bug. In dev, we cache the
MappedAssetobjects. Before this PR,MappedAsset->javascriptImports[0]->assetwas also aMappedAssetobject.Suppose
app.jsimportsfoo.jswhich importsbar.js. Then, the user changesfoo.jsto also importbaz.js.The
foo.jsMappedAsset will now have TWOJavaScriptImportobjects (forbar.jsandbaz.js). However, when we calculate the preloads, this happens:MappedAssetforapp.jsbecause this file has not changedJavaScriptImportforfoo.jsJavaScriptImport->assetproperty holds an OUT-OF-DATE version of theMappedAssetforfoo.js... because it was cached inside theMappedAssetstructure forapp.js. This out-of-dateMappedAssetforfoo.jsonly contains the ONE JavaScript import.The result is that
baz.jswill be missing from the preloads.This PR breaks the structure by only storing the asset's logical path (and sourcePath - needed by the cache system). Then, at runtime, we load the fresh
MappedAssetfrom the logical path.Cheers!