Add some more non-countable English nouns #52526
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
|
There's a coding standards failure in code I didn't really change - at least not in a way that changes the style. I'm happy to add the changes anyway, if appropriate? (The coding standard patch seems to use the str_contains function, which I think was new in PHP 8, so I assume we don't really want that in Symfony 5.4?) |
|
Looking at this again, history -> histories is probably valid (though there are situations where history is also a valid plural). Health is trickier. There are a few places that suggest things like this: So possibly we just conclude that English is an inconsistent mess. |
|
regarding |
Perhaps yes, but I think it's mostly going to sounds strange with the s. In fact, I think there's an argument to be made that nouns ending "LTH" are almost always uncountable. Though I haven't even heard of some of these... |
8527dfd to
cd6a28c
Compare
|
Thank you @paullallier. |
|
Oh, now I got plural "settingss" out of "settings" - should I open new issue? |
|
@acirulis please do |
@acirulis spotted that equipment was missing here: api-platform/core#5957
I've added that and a few more non-countable nouns that I think are reasonably likely to be used by someone. Arguably, time and work could also be here since they are normally non-countable, but there cases where times and works would be correct too.
And I corrected vocal to vowel, which is the correct English term
I'm not sure if this needs extra tests - happy to add if needed.