[DomCrawler] UriResolver support path with colons #52579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Thanks for your PR. You are targeting branch "5.4" but it seems your PR description refers to branch "6.3". Cheers! Carsonbot |
mtarld
approved these changes
Nov 14, 2023
fa4b814 to
89009aa
Compare
|
Thank you @vdauchy. |
This was referenced Nov 17, 2023
nicolas-grekas
pushed a commit
to lyrixx/symfony
that referenced
this pull request
Nov 17, 2023
nicolas-grekas
added a commit
that referenced
this pull request
Nov 17, 2023
…ith colons" (lyrixx) This PR was squashed before being merged into the 5.4 branch. Discussion ---------- [DomCrawler] Revert "bug #52579 UriResolver support path with colons" | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | fix #52628 | License | MIT Commits ------- 790fb38 [DomCrawler] Revert "bug #52579 UriResolver support path with colons"
nicolas-grekas
added a commit
that referenced
this pull request
Nov 20, 2023
* 5.4: [Cache][Lock] Fix PDO store not creating table + add tests Closes #51936-Added Missing translations for Czech (cs) in validators.cs.xlf file Added missing translations in turkish and updated validators.tr.xlf [Serializer] Fix denormalizing date intervals having both weeks and days [Validator] updated Turkish translation [Serializer] Fix denormalize constructor arguments Add some more non-countable English nouns Add hint that changing input arguments has no effect [DomCrawler] Revert "bug #52579 UriResolver support path with colons" [VarExporter] Fix handling mangled property names returned by __sleep() Update Github template for 7.1
nicolas-grekas
added a commit
that referenced
this pull request
Nov 20, 2023
* 6.3: [Cache][Lock] Fix PDO store not creating table + add tests Closes #51936-Added Missing translations for Czech (cs) in validators.cs.xlf file Added missing translations in turkish and updated validators.tr.xlf [Serializer] Fix denormalizing date intervals having both weeks and days [Validator] updated Turkish translation [Serializer] Fix denormalize constructor arguments Add some more non-countable English nouns Add hint that changing input arguments has no effect [DomCrawler] Revert "bug #52579 UriResolver support path with colons" [VarExporter] Fix handling mangled property names returned by __sleep() Update Github template for 7.1
nicolas-grekas
added a commit
that referenced
this pull request
Nov 20, 2023
* 6.4: [FrameworkBundle] Add TemplateController to the list of allowed controllers for fragments [Cache][Lock] Fix PDO store not creating table + add tests Closes #51936-Added Missing translations for Czech (cs) in validators.cs.xlf file Added missing translations in turkish and updated validators.tr.xlf [Serializer] Fix denormalizing date intervals having both weeks and days [Validator] updated Turkish translation [Serializer] Remove wrong final tags [Serializer] Fix denormalize constructor arguments Add some more non-countable English nouns Add hint that changing input arguments has no effect register the virtual request stack together with common profiling services Don't lose checkpoint state when lock is acquired from another [DomCrawler] Revert "bug #52579 UriResolver support path with colons" [VarExporter] Fix handling mangled property names returned by __sleep() Update Github template for 7.1 Fix memory limit in PhpSubprocess unit test
nicolas-grekas
added a commit
that referenced
this pull request
Nov 20, 2023
* 7.0: [FrameworkBundle] Add TemplateController to the list of allowed controllers for fragments [Cache][Lock] Fix PDO store not creating table + add tests Closes #51936-Added Missing translations for Czech (cs) in validators.cs.xlf file Added missing translations in turkish and updated validators.tr.xlf [Serializer] Fix denormalizing date intervals having both weeks and days [Validator] updated Turkish translation [Serializer] Remove wrong final tags [Serializer] Fix denormalize constructor arguments Add some more non-countable English nouns Add hint that changing input arguments has no effect register the virtual request stack together with common profiling services Don't lose checkpoint state when lock is acquired from another [DomCrawler] Revert "bug #52579 UriResolver support path with colons" [DoctrineBridge] Fix use "attribute" driver by default [VarExporter] Fix handling mangled property names returned by __sleep() Update Github template for 7.1 [WebProfilerBundle] Mark CodeExtension as non-internal Fix memory limit in PhpSubprocess unit test
This was referenced Nov 26, 2023
Merged
Merged
Merged
Merged
|
See #58218 |
nicolas-grekas
added a commit
that referenced
this pull request
Sep 11, 2024
This PR was merged into the 5.4 branch. Discussion ---------- Work around `parse_url()` bug | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #52579, #54332 | License | MIT Works around * php/php-src#12703 Commits ------- fb76e53 Work around parse_url() bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolving links on pages using weird pagination like:
https://localhost/domain/search/page:5fails due to:makingReturn
false(and not null as expected in the code).This simply ensure the absolute URL is returned only if the SCHEME is found (ie a string is returned by
parse_url).