Skip to content

[AssetMapper] Fix resolving jsdeliver default + other exports from modules #52617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ogizanagi
Copy link
Contributor

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #52616
License MIT

Fixes resolving:

import i,{Headers as a}from"/npm/@supabase/node-fetch@2.6.14/+esm"

i.e both default export and other exports in a same import.

@carsonbot carsonbot added this to the 7.1 milestone Nov 16, 2023
@ogizanagi ogizanagi changed the base branch from 7.1 to 6.4 November 16, 2023 18:25
@symfony symfony deleted a comment from carsonbot Nov 16, 2023
@ogizanagi ogizanagi modified the milestones: 7.1, 6.4 Nov 16, 2023
Copy link
Member

@weaverryan weaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful bug report and PR. This is VERY well tested for all of the syntaxes we found. Tests are green, so we're good 👍

@fabpot
Copy link
Member

fabpot commented Nov 25, 2023

Thank you @ogizanagi.

@fabpot fabpot merged commit 7096a1e into symfony:6.4 Nov 25, 2023
This was referenced Nov 26, 2023
@ogizanagi ogizanagi deleted the fix-asset-mapper-jsdeliver-regex-supabase branch April 6, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AssetMapper] jsdeliver format issue with supabase-js
4 participants