Skip to content

[Messenger] Fix support for Redis Sentinel using php-redis 6.0.0 #52627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

pepeh
Copy link
Contributor

@pepeh pepeh commented Nov 17, 2023

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #52487
License MIT

Added support for php-redis 6.0.0 to Symfony/Component/Messenger/Bridge/Redis/Transport/Connection.
A similar fix done for RedisTrait before #51683

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@pepeh
Copy link
Contributor Author

pepeh commented Nov 17, 2023

The code on the 6.3 and 6.4 branches is different, I'm not sure what's better, to do the fix in 6.4, because the release will be this month or in 6.3 and then second PR for 6.4?

@pepeh
Copy link
Contributor Author

pepeh commented Nov 17, 2023

PR based on SF 6.3 will be created.

@pepeh pepeh closed this Nov 17, 2023
@pepeh pepeh deleted the fix_52487 branch November 17, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants