Skip to content

Hint that changing input arguments has no effect #52633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2023
Merged

Hint that changing input arguments has no effect #52633

merged 1 commit into from
Nov 18, 2023

Conversation

fschmtt
Copy link
Contributor

@fschmtt fschmtt commented Nov 17, 2023 •
edited by nicolas-grekas
Loading

Q A
Branch? 7.1
Bug fix? no
New feature? no
Deprecations? no
Issues #52415
License MIT

Adding a hint to \Symfony\Component\Console\Event\ConsoleCommandEvent that changing the input arguments has no effect.

@fschmtt fschmtt requested a review from chalasr as a code owner November 17, 2023 17:03
@carsonbot carsonbot added this to the 6.3 milestone Nov 17, 2023
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@alexislefebvre
Copy link
Contributor

The issue

mentioned Symfony 5.4. Should this PR target the 5.4 branch?

@nicolas-grekas nicolas-grekas modified the milestones: 6.3, 7.1 Nov 17, 2023
@nicolas-grekas nicolas-grekas changed the base branch from 6.3 to 7.1 November 17, 2023 21:02
@fabpot fabpot changed the base branch from 7.1 to 5.4 November 18, 2023 18:23
@fabpot fabpot modified the milestones: 7.1, 5.4 Nov 18, 2023
@fabpot fabpot force-pushed the add-hint-on-changing-input-args branch from 577482c to 9ec9ead Compare November 18, 2023 18:23
@fabpot
Copy link
Member

fabpot commented Nov 18, 2023

Thank you @fschmtt.

@fabpot fabpot merged commit 823cc1f into symfony:5.4 Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@stof stof stof approved these changes

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

@lyrixx lyrixx Awaiting requested review from lyrixx

@yceruto yceruto Awaiting requested review from yceruto

@dunglas dunglas Awaiting requested review from dunglas

@OskarStark OskarStark Awaiting requested review from OskarStark

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
6 participants
@fschmtt @carsonbot @alexislefebvre @fabpot @stof @nicolas-grekas