Skip to content

[Serializer] Fix constructor deserialization path #52683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

mtarld
Copy link
Contributor

@mtarld mtarld commented Nov 22, 2023

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #44925
License MIT

This fix doesn't have to be upmerged because it already has been covered by #46680.

@nicolas-grekas
Copy link
Member

Thank you @mtarld.

@nicolas-grekas nicolas-grekas merged commit a560853 into symfony:5.4 Nov 23, 2023
@mtarld mtarld deleted the fix/deserialization-path branch November 24, 2023 01:55
xabbuh added a commit that referenced this pull request Nov 24, 2023
…ctor (mtarld)

This PR was merged into the 5.4 branch.

Discussion
----------

[Serializer] Fix deserialization_path missing using contructor

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        | Fix #44925 #52683
| License       | MIT

While trying to fix #44925, I used a wrong approach (#52683), and therefore introduced a bug.

This PR fixes it and solve the previous issue in a better way.

Commits
-------

8a33f53 [Serializer] Fix deserialization_path missing using contructor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants