[Serializer] [PropertyAccessor] Ignore non-collection interface generics #52699
+39
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about considering this as an improvement and merging into 6.4? Then we can do the BC break in 7.0. |
|
It also means that it won't be supported in 6.3 and 7.0 (supposing that the |
a170c98 to
788659f
Compare
788659f to
a59732f
Compare
a59732f to
eaac5c8
Compare
eaac5c8 to
7f06cac
Compare
7f06cac to
487b24c
Compare
487b24c to
9ecc19d
Compare
maxhelias
approved these changes
Apr 5, 2024
stof
reviewed
Apr 5, 2024
9ecc19d to
7b0d86b
Compare
7b0d86b to
e31aeeb
Compare
fabpot
approved these changes
Jun 9, 2024
|
Thank you @mtarld. |
|
@mtarld I have merged these changes up to the |
nicolas-grekas
added a commit
that referenced
this pull request
Jun 26, 2024
This PR was merged into the 7.1 branch. Discussion ---------- [PropertyInfo] Fix generics related test | Q | A | ------------- | --- | Branch? | 7.1 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Issues | | License | MIT Update tests accordingly to #52699 (in the same way as the legacy tests). Commits ------- 9245561 [PropertyInfo] Fix generics related test
This was referenced Jun 28, 2024
Merged
Merged
Merged
Merged
|
HI, since that we're observing a
|
xabbuh
added a commit
that referenced
this pull request
Jul 6, 2024
… (mtarld) This PR was merged into the 5.4 branch. Discussion ---------- [PropertyInfo] Handle collection in PhpStan same as PhpDoc | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Issues | Fix #52699 (comment) | License | MIT On #52699, a [comment](#52699 (comment)) suggested to support classes that inherit from collection classes (such as doctrine collections for example). This has been done for PHPDoc, but not in PHPStan. This PR adds this missing behavior to PHPStan (and adds the missing PHPDoc related test). Commits ------- f098683 [PropertyInfo] Handle collection in PhpStan same as PhpDoc
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PhpDocExtractorandPhpStanDocExtractorare following an old version of PSR-5 with used to define collections as the following:But, it does conflict with non-collection generics.
This issue will automatically be solved if the
TypeInfois merged in Symfony. But for older versions (<7.1 at least), it needs a fix.I was not able to find a proper bug fix without introducing a BC break, so this PR proposes to opt-on the "non-collection generics" parsing, such asstcClass<int>for example.To opt-out from parsing these generics, it'll be required to setignore_docblock_genericsin the context. And this key/value will become obsolete as soon as theTypeInfois introduced.I'm not sure how to proceed though, should we only merge it in 5.4, and 6.3 supposing that theTypeInfomight be merged in 7.x? Should we document it only in these branches?EDIT: I finally ignored PHPDoc generics that aren't well known collection generic types so that the process will fall back to other resolvers (such as reflection resolver for example)