[AssetMapper] Exclude dot files #52712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🥇 🧞♂️ 🙇♂️ You're amazing, thank you! |
|
For me it should 100% be the default behaviour, as the files do change their "nature" (losing the "dotfile" type on the way). If it's not enabled per default, i'd like a commented (+explanation) setting in the configuration / recipe :) Thanks again for the quick reaction @weaverryan |
fabpot
approved these changes
Nov 25, 2023
|
Thank you @weaverryan. |
Merged
fabpot
added a commit
that referenced
this pull request
Nov 26, 2023
This PR was merged into the 6.4 branch. Discussion ---------- CS: typo fix | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Issues | Fix typo | License | MIT appendix to #52712 Commits ------- 3c38467 CS: typo fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #52697. The biggest question is: should we do this? Is it enough to say "Hey! When you map an assets directory, EVERYTHING is published publicly?". Or should we be on the safe side and exclude dot files by default.
Cheers!