[AssetMapper] Fix: also download files referenced by url() in CSS #52725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
commented
Nov 24, 2023
|
|
||
| if ($extraFileResponses) { | ||
| goto download_extra_files; | ||
| } |
There was a problem hiding this comment.
This got a bit complex because it needs to be recursive (first.css has a url() pointing to second.css, so then we need to check second.css also for url()). However, the recursion is tested, though I don't know of any examples "in the wild" to try this on.
I imagine vendor packages importing one css file from another would be quite rare because CSS files are always packaged into one to reduce requests (even with HTTP2 this is still important for CSS files, as they are page-render-blocking and you can't discover that you need to download second.css until you download first.css).
69b0e16 to
ca90ed8
Compare
|
Thank you @weaverryan. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
@tacman found another situation where our "asset downloader" wasn't complete.
If we're downloading a CSS file, it may reference other files via
url(). In #52620, these were font files, but they could be images or even other CSS Files. Currently, we do NOT download these, so the local references fail. This fixes that. I tried to keep the PR as small as possible, given the late stage of 6.4. But this is a bug fix: the downloader currently doesn't work for CSS files withurl()inside.Tested locally on ux.symfony.com with the bootstrap-icons package.
Cheers!