[Serializer] Consider SerializedPath in debug command output #52730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschaedl
commented
Nov 25, 2023
Comment on lines
109
to
115
| if ($serializedName = $attributeMetadata->getSerializedName()) { | ||
| $data[$attributeMetadata->getName()]['serializedName'] = $serializedName; | ||
| } | ||
|
|
||
| if ($serializedPath = $attributeMetadata->getSerializedPath()) { | ||
| $data[$attributeMetadata->getName()]['serializedPath'] = (string) $serializedPath; | ||
| } |
There was a problem hiding this comment.
It outputs information of either SerializedName or SerializedPath, because both cannot be used in combination for the same property.
37ca037 to
1795e99
Compare
OskarStark
approved these changes
Nov 25, 2023
fabpot
reviewed
Nov 26, 2023
fabpot
approved these changes
Nov 26, 2023
|
Thank you @jschaedl. |
dfbeb1d to
24cdc43
Compare
OskarStark
added a commit
to symfony/symfony-docs
that referenced
this pull request
Dec 11, 2023
…ding `serializedPath` (jschaedl) This PR was squashed before being merged into the 7.1 branch. Discussion ---------- Improve `debug:serializer` command documentation by adding `serializedPath` symfony/symfony#52730 Commits ------- 2c88dc8 Improve `debug:serializer` command documentation by adding `serializedPath`
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
debug:serializercommand does not showSerializedPathinformation and I figured it might makes sense to add it.Corresponding symfony-docs pr symfony/symfony-docs#19184