[Validator] Made tests forward-compatible with ICU 72.1 #52740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9fd5703 to
0ee9933
Compare
xabbuh
approved these changes
Nov 27, 2023
|
We could update some tests in the Form component in a similar manner (relates to #51049). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with ICU 72.1 (CLDR 42), the INTL extension renders a so-called narrow non-breaking space into various localized date and time formats. Our CI does not catch that change yet because it runs an older version of the ICU library.
I'm running PHP on a Mac with Homebrew as package manager which already ships a newer ICU (73.2 currently). This causes a lot of validator tests to fail because they expect a space in time expressions like
12:00 AMwhere a NNBSP character is rendered instead.This change is an attempt to give me a green test suite while maintaining the ability to run against older ICU versions, such as the one our CI uses.