Skip to content

[Security] Document BC break with $secret parameter introduction #52747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 27, 2023
Merged

[Security] Document BC break with $secret parameter introduction #52747

merged 1 commit into from
Nov 27, 2023

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Nov 26, 2023

Q A
Branch? 6.4
Bug fix? no
New feature? no
Deprecations? no
Issues -
License MIT

Deprecation was converted to an exception #52469

@carsonbot carsonbot added this to the 6.4 milestone Nov 26, 2023
@fabpot
Copy link
Member

fabpot commented Nov 27, 2023

Good catch, thanks @wouterj.

@fabpot fabpot merged commit 987e8af into symfony:6.4 Nov 27, 2023
@wouterj wouterj deleted the secret-bcbreak branch November 27, 2023 09:53
@RobertMe
Copy link
Contributor

Thanks, it also was an oversight in my PR (#52724) to actually make the argument required.

@wouterj
Copy link
Member Author

wouterj commented Nov 28, 2023 •
edited
Loading

Your PR is what triggered me to look at the UPGRADE guide for this parameter. So indirectly, you've helped fix this as well ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Security Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
4 participants
@wouterj @fabpot @RobertMe @carsonbot