Skip to content

[Serializer] Add discriminator map to debug commmand output #52749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jschaedl
Copy link
Contributor

@jschaedl jschaedl commented Nov 26, 2023

Q A
Branch? 7.1
Bug fix? no
New feature? little addition
Deprecations? no
Issues -
License MIT

The discriminator mapping was missing in the debug:serializer output.

In case a #[DiscriminatorMap] is configured the output will now look like this:

https://github.com/symfony/symfony/pull/52749/files#diff-d5830f2c54bb89f9819ca3c7c357a2f8df9319cf4d82f71b0704e693a2bfe9ceR106-R109

Copy link
Contributor

@mtarld mtarld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks almost good to me!

@jschaedl jschaedl force-pushed the serializer-add-discriminatormap-to-debug-commmand branch from d49cf24 to 48757d1 Compare January 8, 2024 10:03
@xabbuh xabbuh modified the milestones: 7.1, 7.2 May 15, 2024
@fabpot fabpot modified the milestones: 7.2, 7.3 Nov 20, 2024
@fabpot fabpot force-pushed the serializer-add-discriminatormap-to-debug-commmand branch from 48757d1 to bb0b407 Compare March 1, 2025 16:13
@fabpot
Copy link
Member

fabpot commented Mar 1, 2025

Thank you @jschaedl.

@fabpot fabpot merged commit 8e47989 into symfony:7.3 Mar 1, 2025
8 of 11 checks passed
@fabpot fabpot mentioned this pull request May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants