[Cache] Fix Couchbase password parsing #52758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbc9c21 to
1395af4
Compare
src/Symfony/Component/Cache/Adapter/CouchbaseCollectionAdapter.php
Outdated
Show resolved
Hide resolved
7095459 to
ed359c0
Compare
|
What about deprecating the Couchbase Bucket adapter in another PR? It is only compatible with Couchbase 2, which conflicts with this adapter compatible with Couchbase 3 |
ed359c0 to
6265c18
Compare
58254fe to
00bd19c
Compare
|
After discussing with @nicolas-grekas, the following changes have been made:
Note: |
00bd19c to
ea1ccc4
Compare
|
Rebased and conflicts fixed. All green 🙂 |
src/Symfony/Component/Cache/Adapter/CouchbaseCollectionAdapter.php
Outdated
Show resolved
Hide resolved
ea1ccc4 to
4e6f052
Compare
|
It seems 😕 https://3v4l.org/eshPt I'll have a look at it. Is this something that also should target 7.1? I'd say yes. |
|
Thank you @alexandre-daubois. |
nicolas-grekas
added a commit
that referenced
this pull request
Jan 2, 2024
…fier][Translation] Url decode username and passwords from `parse_url()` results (alexandre-daubois) This PR was merged into the 5.4 branch. Discussion ---------- [Cache][DependencyInjection][Lock][Mailer][Messenger][Notifier][Translation] Url decode username and passwords from `parse_url()` results | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | - | License | MIT Following #52758 (review) I guess this doesn't an entry in the changelog, does it? I replaced `urldecode` by `rawurldecode` and `$parsedDsn` by `$params`, as latest updates to the code used the latter. Commits ------- f0292f2 [Cache][DependencyInjection][Lock][Mailer][Messenger][Notifier][Translation] Url decode username and passwords from `parse_url()` results
symfony-splitter
pushed a commit
to symfony/cache
that referenced
this pull request
Jan 2, 2024
…fier][Translation] Url decode username and passwords from `parse_url()` results (alexandre-daubois) This PR was merged into the 5.4 branch. Discussion ---------- [Cache][DependencyInjection][Lock][Mailer][Messenger][Notifier][Translation] Url decode username and passwords from `parse_url()` results | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | - | License | MIT Following symfony/symfony#52758 (review) I guess this doesn't an entry in the changelog, does it? I replaced `urldecode` by `rawurldecode` and `$parsedDsn` by `$params`, as latest updates to the code used the latter. Commits ------- f0292f23be [Cache][DependencyInjection][Lock][Mailer][Messenger][Notifier][Translation] Url decode username and passwords from `parse_url()` results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the followup for #52688 (comment).