[Serializer] Use DenormalizerAwareInterface instead of SerializerAwareInterface #52764
Conversation
The UnwrappingDenormalizer does not depend on the SerializerInterface. Using the DenormalizerInterfacce is enough, because only denormalize is called. Also, the SerializerInterface does not define method denormalize and it currently only works, because at runtime the serializer service is injected, which implements the DenormalizerInterface.
|
This is a breaking change that we need a deprecation layer for. By removing |
|
Hi @derrabus,
You are right, I missed this. I am going to add a deprecation layer. |
94663b7 to
c4542ef
Compare
c4542ef to
4dea4e0
Compare
|
|
||
| /** | ||
| * @author Eduard Bulava <bulavaeduard@gmail.com> | ||
| */ | ||
| final class UnwrappingDenormalizer implements DenormalizerInterface, SerializerAwareInterface |
There was a problem hiding this comment.
I think we should keep SerializerAwareInterface as long as we implement setSerializer().
There was a problem hiding this comment.
If we implement SerializerAwareInterface, the Serializer class will be calling the deprecated method.
There was a problem hiding this comment.
Yes, that's the reason why I removed SerializerAwareInterface. The Serializer class will call setSerializer() here: https://github.com/symfony/symfony/blob/7.1/src/Symfony/Component/Serializer/Serializer.php#L85
But without it, its a bc-break for code relying on UnwrappingDenormalizer implementing SerializerAwareInterface. I am not sure how to solve this problem.
The
UnwrappingDenormalizerdoes not depend on theSerializerInterface. Using theDenormalizerInterfacceis enough, because onlydenormalize()is called. Also, theSerializerInterfacedoes not define methoddenormalize()and it currently only works, because at runtime theserializerservice is injected, which implements theDenormalizerInterface.