Skip to content

[ExpressionLanguage][PasswordHasher][Stopwatch] Improve overall coverage #52771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2024
Merged

[ExpressionLanguage][PasswordHasher][Stopwatch] Improve overall coverage #52771

merged 1 commit into from
Jan 23, 2024

Conversation

alexandre-daubois
Copy link
Member

@alexandre-daubois alexandre-daubois commented Nov 28, 2023 •
edited
Loading

Q A
Branch? 7.1
Bug fix? no
New feature? no
Deprecations? no
Issues -
License MIT

@carsonbot carsonbot added this to the 5.4 milestone Nov 28, 2023
alexandre-daubois
alexandre-daubois commented Nov 28, 2023
View reviewed changes
src/Symfony/Component/PasswordHasher/Tests/Hasher/NativePasswordHasherTest.php
public function testInvalidCostThrows(int $cost)
{
$this->expectException(\InvalidArgumentException::class);
$this->expectExceptionMessageMatches('/\$cost must be in the range of (\d+)-(\d+)\./');
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using regex in this file to be future-proof about limits that could change

@alexandre-daubois
Copy link
Member Author

Agree with everything, thank you @stof, that's addressed 👍

@alexandre-daubois alexandre-daubois force-pushed the hasher-expr-watch-cov branch 2 times, most recently from d345be1 to 867711b Compare November 29, 2023 08:13
@alexandre-daubois alexandre-daubois changed the base branch from 5.4 to 6.4 November 29, 2023 08:13
@alexandre-daubois
Copy link
Member Author

Rebased on 6.4, like #52746

@OskarStark
Copy link
Contributor

As this PR only changes test files, I would vote to merge into 5.4

@alexandre-daubois
Copy link
Member Author

Hi 👋 Should this be rebased to 5.4 again or rebase to 7.1? 🙂

@nicolas-grekas
Copy link
Member

Let's rebase for 7.1 - this will still help spot issues on 5.4 when merging up changes from there.

@nicolas-grekas nicolas-grekas modified the milestones: 5.4, 7.1 Jan 23, 2024
@alexandre-daubois alexandre-daubois changed the base branch from 6.4 to 7.1 January 23, 2024 09:06
@alexandre-daubois
Copy link
Member Author

Here you go, that's rebased 🙂

@nicolas-grekas
Copy link
Member

Thank you @alexandre-daubois.

@nicolas-grekas nicolas-grekas merged commit 262efc3 into symfony:7.1 Jan 23, 2024
@alexandre-daubois alexandre-daubois mentioned this pull request Jul 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof left review comments

@OskarStark OskarStark OskarStark left review comments

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

@lyrixx lyrixx Awaiting requested review from lyrixx

@yceruto yceruto Awaiting requested review from yceruto

@dunglas dunglas Awaiting requested review from dunglas

@xabbuh xabbuh Awaiting requested review from xabbuh

@welcoMattic welcoMattic Awaiting requested review from welcoMattic

@kbond kbond Awaiting requested review from kbond

@jderusse jderusse Awaiting requested review from jderusse

Assignees
No one assigned
Labels
ExpressionLanguage PasswordHasher Status: Needs Review Stopwatch
Projects
None yet
Milestone
7.1
Development

Successfully merging this pull request may close these issues.
5 participants
@alexandre-daubois @OskarStark @nicolas-grekas @stof @carsonbot