[Form] Fix DateTypeTest #52792
[Form] Fix DateTypeTest #52792
Conversation
The date submitted cause an unexcpected Intl date parse error exception.
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
The date submitted is invalid and cause an unexcpected Intl date parse error exception.
The date submitted is invalid and cause an unexcpected Intl date parse error exception.
The date submitted is invalid and cause an unexcpected Intl date parse error exception.
The date submitted is invalid and cause an unexcpected Intl date parse error exception.
|
I am not sure about this change. Doesn’t it indicate that existing applications will break when certain ICU versions are installed? |
|
Hello @xabbuh, I've tested with this ICU versions: ICU version => 71.1 |
|
The test in question does not fail on my machine (ICU 73.2), neither with nor without this change. |
|
I think that explains things. If I remember correctly the behaviour changed with ICU 71. So changing the test would only mean that the CI would pass with ICU 71.1, but that would hide the underlying issue as your users would suddenly not be able anymore to fill the form as they used to before. |
|
or maybe it's just 71.1 that is buggy (see #52245) |
|
I updated #52245 instead to skip the failing tests with ICU 71.1, thanks for pushing this forward |
The date submitted cause an unexcpected Intl date parse error exception.
I've fixed a test related to DateType that failed because submit an invalid format expected throwing a Intl parse exception.