[Routing] Fix conflicting FQCN aliases with route name #52805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fancyweb
commented
Nov 29, 2023
fancyweb
commented
Nov 29, 2023
|
|
||
| use Symfony\Component\Routing\Attribute\Route; | ||
|
|
||
| #[Route(path: '/foobarccc', name: self::class)] |
There was a problem hiding this comment.
I added only this test fixture case but the 3 FQCN aliases are susceptible to fail.
3c02106 to
bb04dd5
Compare
bb04dd5 to
96a0d41
Compare
96a0d41 to
18494c8
Compare
stof
approved these changes
Nov 29, 2023
|
Thank you @fancyweb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the route name === the FQCN alias we want to add,
addAlias()throws. In this case, we can safely ignore the exception and move on.