[Routing] Fix removing aliases pointing to removed route in RouteCollection::remove()
#52806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yceruto
approved these changes
Nov 29, 2023
|
Thank you @fancyweb. |
|
AFAICT, the goal was not to remove the aliases pointing to a route but really to remove the alias when passing the alias name. |
|
This PR makes it impossible to remove an alias. |
This was referenced Nov 30, 2023
nicolas-grekas
added a commit
that referenced
this pull request
Dec 1, 2023
…ve() (fancyweb) This PR was merged into the 5.4 branch. Discussion ---------- [Routing] Restore aliases removal in RouteCollection::remove() | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | #52806 (comment) | License | MIT As suggested in #52831 (comment) It's still a small behavior change on 5.4, let's see what people think 😃 Commits ------- 3c6dc17 [Routing] Restore aliases removal in RouteCollection::remove()
This was referenced Dec 1, 2023
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a route is removed from the collection, we want to remove all aliases pointing to it. The implementation is flawed because the
$aliasesarray is indexed by the alias name, and not by the route since several aliases can point to the same route.It'll fix the related issue because added FQCN aliases will be correctly removed when
PrefixTrait::addPrefix()removes the route before reading it for each locale.