Skip to content

[Serializer] Do not instantiate object if it is not instantiable #52817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 20, 2023
Merged

[Serializer] Do not instantiate object if it is not instantiable #52817

merged 1 commit into from
Dec 20, 2023

Conversation

maxbaldanza
Copy link
Contributor

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Issues
License MIT

If you pass an object that can't be instantiable such as enum to deserialize then you get the following
error Error: Cannot instantiate enum as the object is tried to be created without checking if it's instantiable

@maxbaldanza maxbaldanza requested a review from dunglas as a code owner November 30, 2023 10:31
@carsonbot carsonbot added this to the 5.4 milestone Nov 30, 2023
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@maxbaldanza
Copy link
Contributor Author

I'm not sure if the psalm error is related to something I've changed here as it fails when generating the baseline.
If it's something I've changed then let me know and I can take a look 😄

@maxbaldanza maxbaldanza force-pushed the do-not-instantiate-object branch 2 times, most recently from a26d9ba to 723dc33 Compare December 1, 2023 16:25
@maxbaldanza maxbaldanza force-pushed the do-not-instantiate-object branch from 723dc33 to 0c80436 Compare December 11, 2023 20:30
@maxbaldanza
Copy link
Contributor Author

@nicolas-grekas / @mtarld anything left for me to do on this one?

@maxbaldanza @fabpot
Do not instantiate object if it is not instantiable
298b15f 
If you pass an object that can't be instantiable such
as enum to deserialize then you get the following
error `Error: Cannot instantiate enum` as the object
is tried to be created without checking if it's instantiable
@fabpot fabpot force-pushed the do-not-instantiate-object branch from 0c80436 to 298b15f Compare December 20, 2023 07:02
@fabpot
Copy link
Member

fabpot commented Dec 20, 2023

Thank you @maxbaldanza.

@fabpot fabpot merged commit 58c4522 into symfony:5.4 Dec 20, 2023
@maxbaldanza maxbaldanza deleted the do-not-instantiate-object branch December 20, 2023 09:49
This was referenced Dec 30, 2023
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@mtarld mtarld mtarld approved these changes

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

@nicolas-grekas nicolas-grekas Awaiting requested review from nicolas-grekas

Assignees
No one assigned
Labels
Bug Serializer Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
5 participants
@maxbaldanza @carsonbot @fabpot @nicolas-grekas @mtarld