Skip to content

[AssetMapper] Upgrade asset mapper to 6.4 fails due to invalid entries "downloaded_to" and "preload" #52825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 30, 2023
Merged

[AssetMapper] Upgrade asset mapper to 6.4 fails due to invalid entries "downloaded_to" and "preload" #52825

merged 1 commit into from
Nov 30, 2023

Conversation

redflo
Copy link
Contributor

@redflo redflo commented Nov 30, 2023 •
edited by nicolas-grekas
Loading

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? yes and no, entries were deprecated, but upgrade did not handle these
Issues Fix #52810
License MIT

Fixes errors that arise from deprecated entries "downloaded_to" and "preload" after upgrade to Symfony 6.4.
Deprecated parameters are ignored and removed whenever importmap.php is rewritten during importmap:update for example.
Tested with my personal symfony project, and resolved the issue #52810

@carsonbot carsonbot added this to the 6.4 milestone Nov 30, 2023
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@symfony symfony deleted a comment from carsonbot Nov 30, 2023
weaverryan
weaverryan approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@weaverryan weaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this! It's a small change but will help the upgrade. So, I like it. After this is merged (and then merged up into 7.0), we can remove this (including for the url key).

@nicolas-grekas nicolas-grekas changed the title [AssetMapper] Upgrade asset mapper to 6.4 fails due to invalid entrie… [AssetMapper] Upgrade asset mapper to 6.4 fails due to invalid entries "downloaded_to" and "preload" Nov 30, 2023
@nicolas-grekas
Copy link
Member

Thank you @redflo.

@nicolas-grekas nicolas-grekas merged commit 8cd61c5 into symfony:6.4 Nov 30, 2023
@smnandre
Copy link
Member

Thank you @redflo ! That'll smooth things for a lot of people

This was referenced Dec 1, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weaverryan weaverryan weaverryan approved these changes

Assignees
No one assigned
Labels
AssetMapper Bug Deprecation Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
5 participants
@redflo @carsonbot @nicolas-grekas @smnandre @weaverryan