Skip to content

[FrameworkBundle][Serializer] Fix TranslatableNormalizer when the Translator is disabled #52852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 1, 2023
Merged

[FrameworkBundle][Serializer] Fix TranslatableNormalizer when the Translator is disabled #52852

merged 1 commit into from
Dec 1, 2023

Conversation

Jean-Beru
Copy link
Contributor

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #52847
License MIT

Fix #52847 by removing the serializer.normalizer.translatable when the Translator is disabled. FYI, if the Translator is enabled but the class does not exist, an error is already raised before Translation support cannot be enabled as the Translation component is not installed. Try running "composer require symfony/translation".

@carsonbot carsonbot added this to the 6.4 milestone Dec 1, 2023
@nicolas-grekas
Copy link
Member

Thank you @Jean-Beru.

@nicolas-grekas nicolas-grekas merged commit ebf0486 into symfony:6.4 Dec 1, 2023
@greg0ire
Copy link
Contributor

greg0ire commented Dec 1, 2023

Thanks @Jean-Beru !

@carsonbot carsonbot changed the title [Serializer] Fix TranslatableNormalizer when the Translator is disabled [FrameworkBundle][Serializer] Fix TranslatableNormalizer when the Translator is disabled Dec 1, 2023
@Jean-Beru Jean-Beru deleted the fix/translatable-normalizer-when-translator-is-disabled-52847 branch December 1, 2023 16:21
@nicolas-grekas nicolas-grekas mentioned this pull request Dec 1, 2023
Merged
nicolas-grekas added a commit that referenced this pull request Dec 1, 2023
@nicolas-grekas
minor #52855 [FrameworkBundle] Fix tests (nicolas-grekas)
fdf40f8 
This PR was merged into the 6.4 branch.

Discussion
----------

[FrameworkBundle] Fix tests

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

Needed after #52852

Commits
-------

e8c6709 [FrameworkBundle] Fix tests
This was referenced Dec 1, 2023
Merged
Merged
@aborza aborza mentioned this pull request Aug 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Bug FrameworkBundle Serializer Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
6 participants
@Jean-Beru @nicolas-grekas @greg0ire @xabbuh @derrabus @carsonbot