remove $ so gitclip works #52865
Merged
remove $ so gitclip works #52865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Thanks for your PR. You are targeting branch "7.1" but it seems your PR description refers to branch "all". Cheers! Carsonbot |
|
We have a lot more README files with that issue. If we change it here, we should change it everywhere. |
|
Agreed! If it gets accepted I can do the rest as well. If it's rejected
(I think it has been in the past), I won't bother.
But it's always bugged me. clip, switch to terminal, paste, ctrl-a,
forward-arrow twice, backspace twice, enter.
…On Sat, Dec 2, 2023 at 7:57 AM Alexander M. Turek ***@***.***> wrote:
We have a lot more README files with that issue. If we change it here, we
should change it everywhere.
—
Reply to this email directly, view it on GitHub
<#52865 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEXIQO344CXK6U32HPF6CLYHMQU3AVCNFSM6AAAAABAD7YYX6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZXGE2DENZQGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
If you have a link to a previous discussion, this might help getting a decision here. |
|
Not sure -- I've submitted this issue to many repositories, but even if it
was rejected, it shouldn't be. Nobody wants the $ in the clipboard when
they're pasting.
And the $ isn't even the prompt for windows, so it's not like it's so
important that we need to have it even though it makes it look like it
doesn't work.
…On Sat, Dec 2, 2023 at 10:36 AM Alexander M. Turek ***@***.***> wrote:
If it's rejected (I think it has been in the past), I won't bother.
If you have a link to a previous discussion, this might help getting a
decision here.
—
Reply to this email directly, view it on GitHub
<#52865 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEXIQKLN3BB6E2C2JF6SA3YHNDJRAVCNFSM6AAAAABAD7YYX6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZXGE4DIMBTGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
It was discussed recently there https://symfony.com/blog/new-in-symfony-6-4-assetmapper-improvements Maybe it is possible to filter this char for Windows users just before it’s copied into the clipboard ? |
OskarStark
approved these changes
Dec 3, 2023
|
👍 for every README file across the board, once for all. |
|
13 in this repo it seems |
fabpot
approved these changes
Dec 8, 2023
|
Thank you @tacman. |
|
Follow-up in ecc628a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the copy button puts the $ into the clipboard, so it work or to simply paste it on the command line.