[Messenger] Fix missing @throws phpdoc on MiddlewareInterface, MessageBusInterface and SenderInterface
#52915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
approved these changes
Dec 6, 2023
…ageBusInterface and SenderInterface
d2749eb to
70a74b7
Compare
|
Thank you @VincentLanglet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@throwsphpdoc help the developper to know those methods can throw an exception and to have a contract about which exception can be thrown.I recently got an exception in production because of the call
$messageBus->dispatch()without knowing it could throw an exception. Seems like it's because it iterable on every Middleware and a lot of middleware are throwing exception.As an example:
TransportExceptionin case of errors, which happen in the SendMessageMiddleware.