[Serializer] Fix unexpected allowed attributes #52917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fabbot errors aren't related to that PR. |
6839596 to
9a3d2be
Compare
chalasr
reviewed
Dec 6, 2023
src/Symfony/Component/Serializer/Normalizer/GetSetMethodNormalizer.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Serializer/Normalizer/GetSetMethodNormalizer.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Serializer/Normalizer/GetSetMethodNormalizer.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Serializer/Normalizer/GetSetMethodNormalizer.php
Outdated
Show resolved
Hide resolved
chalasr
requested changes
Dec 9, 2023
8f93524 to
ee9ccde
Compare
|
Once this PR will be upmerged to 7.1, I'll create a new one to trigger the proper deprecations. |
ee9ccde to
3a87ebe
Compare
chalasr
approved these changes
Jan 13, 2024
There was a problem hiding this comment.
The implementation fits the definition of a new feature to me: adding an argument on a constructor, and adding an argument on public/protected methods.
This should come with an @param annotation for methods, and this will yield a new deprecation.
Maybe another approach is possible? I don't know at all :)
|
That read/write mode do need to be passed throughout method calls to fix the bug at hand, so the plan here is to make it a parameter that's hidden at first on 5.4, then make it virtual on 7.1 and finally make it real on 8.0. @mtarld would that work conceptually and technically? |
e5df998 to
46f78a9
Compare
|
It appears that it works indeed, and it is much better thanks! I'm wondering if we should make that read/write information explicit in 7.1, maybe a context value like here is enough (but it is less secure). |
46f78a9 to
b48471b
Compare
nicolas-grekas
approved these changes
Apr 5, 2024
|
Thank you @mtarld. |
This was referenced Apr 29, 2024
Merged
Merged
Merged
xabbuh
added a commit
to xabbuh/symfony
that referenced
this pull request
Apr 30, 2024
The PropertyNormalizer does not handle a property info extractor. It looks like the argument was accidentally added to instead of the ObjectNormalizer in symfony#52917.
xabbuh
added a commit
to xabbuh/symfony
that referenced
this pull request
Apr 30, 2024
The PropertyNormalizer does not handle a property info extractor. It looks like the argument was accidentally added to instead of the ObjectNormalizer in symfony#52917.
xabbuh
added a commit
to xabbuh/symfony
that referenced
this pull request
Apr 30, 2024
The PropertyNormalizer does not handle a property info extractor. It looks like the argument was accidentally added to instead of the ObjectNormalizer in symfony#52917.
xabbuh
added a commit
to xabbuh/symfony
that referenced
this pull request
Apr 30, 2024
The PropertyNormalizer does not handle a property info extractor. It looks like the argument was accidentally added to instead of the ObjectNormalizer in symfony#52917.
xabbuh
added a commit
to xabbuh/symfony
that referenced
this pull request
Apr 30, 2024
The PropertyNormalizer does not handle a property info extractor. It looks like the argument was accidentally added to instead of the ObjectNormalizer in symfony#52917.
chalasr
added a commit
that referenced
this pull request
May 1, 2024
…or to the ObjectNormalizer (xabbuh) This PR was merged into the 5.4 branch. Discussion ---------- [FrameworkBundle] move wiring of the property info extractor to the ObjectNormalizer | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | | License | MIT The PropertyNormalizer does not handle a property info extractor. It looks like the argument was accidentally added to instead of the ObjectNormalizer in #52917. Commits ------- 518bc28 move wiring of the property info extractor to the ObjectNormalizer
derrabus
added a commit
that referenced
this pull request
May 2, 2024
… setters with optional args (HypeMC) This PR was merged into the 5.4 branch. Discussion ---------- [Serializer] Fix `GetSetMethodNormalizer` not working with setters with optional args | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #54784 | License | MIT Prior to #52917 setters could have an optional argument or even multiple ones. This restores the previous behavior. Commits ------- 74bc0eb [Serializer] Fix `GetSetMethodNormalizer` not working with setters with optional args
|
Those changes generate a big performance drop in one of the projects I work with where we extensively use attributes on DTOs. Comparing Serializer in version |
|
Please open a dedicated issue if you want any follow up. |
This was referenced May 26, 2024
fabpot
added a commit
that referenced
this pull request
Jun 16, 2024
…peMC) This PR was merged into the 5.4 branch. Discussion ---------- [Serializer] Fix `ObjectNormalizer` with property path | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #54983 | License | MIT Caused by #52917. The `ObjectNormalizer::isAllowedAttribute()` method doesn't work with property paths, this is an attempt to fix the problem. Commits ------- 3857545 [Serializer] Fix `ObjectNormalizer` with property path
1 task
symfonyaml
pushed a commit
to symfonyaml/symfony
that referenced
this pull request
Oct 21, 2024
The PropertyNormalizer does not handle a property info extractor. It looks like the argument was accidentally added to instead of the ObjectNormalizer in symfony#52917.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A more accurate approach than #52680