[Messenger] Fix Redis messenger scheme comparison #52930
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
|
Can you please add a test (for |
|
I pushed some tests |
963129f to
1c821bc
Compare
src/Symfony/Component/Messenger/Bridge/Redis/Tests/Transport/RedisTransportFactoryTest.php
Outdated
Show resolved
Hide resolved
68c69cd to
20846e2
Compare
6441d08 to
7477e5f
Compare
|
Please squash your PR and/or allow edits from maintainers. |
Commit 3380518 introduced a new Redis Sentinel DSN for the redis messenger transport which uses a scheme syntax like `redis:?host[rs:1234]&host[rs2:1234]`. Though, the coresponding factory only supports schemes which start with `redis://` or `rediss://` which renders the redis sentinel features for the messenger unusable. This commit fixes the supported schemes by removing the `//` portion of them. fixes symfony#52899
59ab0f9 to
6f4e0a4
Compare
|
Squashed. |
|
Thank you @freswa. |
Commit 3380518 introduced a new Redis Sentinel DSN for the redis messenger transport which uses a scheme syntax like
redis:?host[rs:1234]&host[rs2:1234].Though, the coresponding factory only supports schemes which start with
redis://orrediss://which renders the redis sentinel features for the messenger unusable. This commit fixes the supported schemes by removing the//portion of them.fixes #52899