Skip to content

[DependencyInjection] Remove redundant PHPdoc line #52933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

StefanosPs
Copy link
Contributor

@StefanosPs StefanosPs commented Dec 7, 2023

Q A
Branch? 6.3
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #52932
License MIT

Just remove a Redundant PHPdoc line

@carsonbot carsonbot added this to the 6.3 milestone Dec 7, 2023
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. And you picked the correct branch. Thanks for the patch.

Please note that it is not required to open an issue before a PR.

@carsonbot carsonbot changed the title Remove redundant PHPdoc line [DependencyInjection] Remove redundant PHPdoc line Dec 7, 2023
@OskarStark OskarStark modified the milestones: 6.3, 5.4 Dec 8, 2023
@OskarStark
Copy link
Contributor

Thank you Stefanos.

@OskarStark OskarStark merged commit 96421d3 into symfony:6.3 Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants