-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[WebProfilerBundle] Fix "Copy as cURL" #52937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keichinger
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This indeed fixes the issue I'm having. From my perspective, this one is good to go as soon as the text color in the copied state has been addressed.
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/base_js.html.twig
Outdated
Show resolved
Hide resolved
c74aa81
to
c97f0f9
Compare
welcoMattic
approved these changes
Dec 9, 2023
xabbuh
approved these changes
Dec 9, 2023
OskarStark
approved these changes
Dec 9, 2023
Thank you @HypeMC. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 10, 2023
This PR was merged into the 6.4 branch. Discussion ---------- [WebProfilerBundle] Fix "Copy as cURL" dark style | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #52937 (comment) | License | MIT Followup to #52937, addresses `@javiereguiluz`'s comment. The button no longer changes color when using the dark theme:  Nothing changed when using the light theme:  Commits ------- e4f47f2 [WebProfilerBundle] Fix "Copy as cURL" dark style
symfony-splitter
pushed a commit
to symfony/web-profiler-bundle
that referenced
this pull request
Dec 10, 2023
This PR was merged into the 6.4 branch. Discussion ---------- [WebProfilerBundle] Fix "Copy as cURL" dark style | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix symfony/symfony#52937 (comment) | License | MIT Followup to #52937, addresses `@javiereguiluz`'s comment. The button no longer changes color when using the dark theme:  Nothing changed when using the light theme:  Commits ------- e4f47f258c [WebProfilerBundle] Fix "Copy as cURL" dark style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug was introduced in #50790.
#SymfonyHackday