Skip to content

[WebProfilerBundle] Fix "Copy as cURL" #52937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2023
Merged

Conversation

HypeMC
Copy link
Contributor

@HypeMC HypeMC commented Dec 7, 2023

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #52920
License MIT

The bug was introduced in #50790.

#SymfonyHackday

Copy link
Contributor

@keichinger keichinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This indeed fixes the issue I'm having. From my perspective, this one is good to go as soon as the text color in the copied state has been addressed.

@OskarStark OskarStark changed the title [WebProfilerBundle] Fix Copy as Curl [WebProfilerBundle] Fix "Copy as cURL" Dec 9, 2023
@fabpot
Copy link
Member

fabpot commented Dec 9, 2023

Thank you @HypeMC.

@fabpot fabpot merged commit f58cf04 into symfony:6.4 Dec 9, 2023
@HypeMC HypeMC deleted the fix-copy-as-curl branch December 9, 2023 11:19
nicolas-grekas added a commit that referenced this pull request Dec 10, 2023
This PR was merged into the 6.4 branch.

Discussion
----------

[WebProfilerBundle] Fix "Copy as cURL" dark style

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        | Fix #52937 (comment)
| License       | MIT

Followup to #52937, addresses `@javiereguiluz`'s comment.

The button no longer changes color when using the dark theme:
![dark](https://github.com/symfony/symfony/assets/2445045/dc1dc267-a541-4ab7-8be9-db152d48dc12)

Nothing changed when using the light theme:
![light](https://github.com/symfony/symfony/assets/2445045/13a60002-d02e-42e9-8e08-e967bae4ef6e)

Commits
-------

e4f47f2 [WebProfilerBundle] Fix "Copy as cURL" dark style
symfony-splitter pushed a commit to symfony/web-profiler-bundle that referenced this pull request Dec 10, 2023
This PR was merged into the 6.4 branch.

Discussion
----------

[WebProfilerBundle] Fix "Copy as cURL" dark style

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        | Fix symfony/symfony#52937 (comment)
| License       | MIT

Followup to #52937, addresses `@javiereguiluz`'s comment.

The button no longer changes color when using the dark theme:
![dark](https://github.com/symfony/symfony/assets/2445045/dc1dc267-a541-4ab7-8be9-db152d48dc12)

Nothing changed when using the light theme:
![light](https://github.com/symfony/symfony/assets/2445045/13a60002-d02e-42e9-8e08-e967bae4ef6e)

Commits
-------

e4f47f258c [WebProfilerBundle] Fix "Copy as cURL" dark style
This was referenced Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Profiler][HttpClient] „Copy as cURL” button missing in Symfony 6.4.0 — 6.4.1
8 participants