Skip to content

[Messenger] Fix Redis integration tests data provider #52983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 10, 2023
Merged

[Messenger] Fix Redis integration tests data provider #52983

merged 1 commit into from
Dec 10, 2023

Conversation

alexandre-daubois
Copy link
Member

@alexandre-daubois alexandre-daubois commented Dec 10, 2023 •
edited
Loading

Q A
Branch? 7.1
Bug fix? yes
New feature? no
Deprecations? no
Issues -
License MIT

This fixes the data provider for RedisExtIntegrationTest and add redis_sentinel as a valid option

@carsonbot carsonbot added this to the 7.1 milestone Dec 10, 2023
@alexandre-daubois alexandre-daubois force-pushed the redis-tests-fix branch 6 times, most recently from f7364fb to baf1581 Compare December 10, 2023 11:01
@alexandre-daubois alexandre-daubois changed the title [Messenger] Fix Redis integration tests [Messenger] Fix Redis integration tests data provider Dec 10, 2023
@alexandre-daubois alexandre-daubois force-pushed the redis-tests-fix branch 2 times, most recently from 49a87ae to b2bf91a Compare December 10, 2023 11:03
@xabbuh
Copy link
Member

xabbuh commented Dec 10, 2023

Good catch, thanks @alexandre-daubois.

@xabbuh xabbuh merged commit dd3ef59 into symfony:7.1 Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Bug Messenger Status: Reviewed
Projects
None yet
Milestone
7.1
Development

Successfully merging this pull request may close these issues.
3 participants
@alexandre-daubois @xabbuh @carsonbot