[Cache] Fix expiration time for CouchbaseCollection #53054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9f26aca to
3e717b8
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Dec 18, 2023
This PR was merged into the 7.1 branch. Discussion ---------- [Cache] Fix CI failing tests | Q | A | ------------- | --- | Branch? | 7.1 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | - | License | MIT Fixes CI, `AbstractAdapter::createConnection` checks the bucket support before falling back to Collection when the DSN starts with `couchbase`. Should fix CI in all versions with #53054 Commits ------- 578eb29 [Cache] Fix failing test
src/Symfony/Component/Cache/Adapter/CouchbaseCollectionAdapter.php
Outdated
Show resolved
Hide resolved
03c665e to
b958250
Compare
fabpot
reviewed
Dec 28, 2023
src/Symfony/Component/Cache/Adapter/CouchbaseCollectionAdapter.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Cache/Adapter/CouchbaseCollectionAdapter.php
Outdated
Show resolved
Hide resolved
b958250 to
e286f38
Compare
|
Thank you @alexandre-daubois. |
This was referenced Dec 30, 2023
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A refactoring has been done in Couchbase extension 3.0.5 about expiry time: https://github.com/couchbase/php-couchbase/releases/tag/v3.0.5 (see PCBC-715)
In order to put things together, let's constantly use an absolute time point here. This also fixes a failing test of integration tests in 6.3.
Tests skipping messages have been updated to match
CouchbaseCollectionAdapter::isSupported().