[Validator] Fix using known option names as field names #53133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HypeMC
commented
Dec 19, 2023
Comment on lines
44
to
46
| $knowOptions = array_map(function (\ReflectionParameter $parameter) { | ||
| return $parameter->name; | ||
| }, (new \ReflectionMethod(__METHOD__))->getParameters()); |
There was a problem hiding this comment.
Suggested change
| $knowOptions = array_map(function (\ReflectionParameter $parameter) { | |
| return $parameter->name; | |
| }, (new \ReflectionMethod(__METHOD__))->getParameters()); | |
| static $knowOptions; | |
| $knownOptions ??= array_column((new \ReflectionMethod(__METHOD__))->getParameters(), 'name'); |
There was a problem hiding this comment.
Done, I had to adjust the code for PHP 7.2. I'm wondering, is the static variable necessary since this all happens in the constructor?
e92d8a1 to
51d1960
Compare
51d1960 to
51ec528
Compare
xabbuh
approved these changes
Dec 24, 2023
fabpot
approved these changes
Dec 24, 2023
|
Thank you @HypeMC. |
This was referenced Dec 30, 2023
Merged
Merged
Merged
Merged
|
Fyi, this breaks code where |
nicolas-grekas
added a commit
that referenced
this pull request
Jan 5, 2024
This PR was merged into the 5.4 branch. Discussion ---------- [Validator] re-allow an empty list of fields | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #53133 (comment) | License | MIT Commits ------- 098c14c re-allow an empty list of fields
symfony-splitter
pushed a commit
to symfony/validator
that referenced
this pull request
Jan 5, 2024
This PR was merged into the 5.4 branch. Discussion ---------- [Validator] re-allow an empty list of fields | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix symfony/symfony#53133 (comment) | License | MIT Commits ------- 098c14cc92 re-allow an empty list of fields
|
I tried this (#53383) fix and it still breaks for an empty list of constraints, which I confirmed was working in For my use case I can mitigate this by using |
|
just had the same problem as @dresslerdemos |
|
I have a fix pending locally. I’ll keep you posted. |
|
@dresslerdemos @nerones Can you check if #53443 fixes it for you? |
nicolas-grekas
added a commit
that referenced
this pull request
Feb 9, 2024
… (xabbuh, HypeMC) This PR was merged into the 5.4 branch. Discussion ---------- [Validator] Fix fields without constraints in `Collection` | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #53133 (comment), Fix #53455 | License | MIT Continuation of #53443. Commits ------- f6217d8 [Validator] Fix fields without constraints in `Collection` b341535 deal with fields for which no constraints have been configured
symfony-splitter
pushed a commit
to symfony/validator
that referenced
this pull request
Feb 9, 2024
… (xabbuh, HypeMC) This PR was merged into the 5.4 branch. Discussion ---------- [Validator] Fix fields without constraints in `Collection` | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix symfony/symfony#53133 (comment), Fix #53455 | License | MIT Continuation of #53443. Commits ------- f6217d87e6 [Validator] Fix fields without constraints in `Collection` b341535558 deal with fields for which no constraints have been configured
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of assuming
$fieldsis not the fields array when any of the keys is a known option, let's assume it is the fields array if all keys are known options. Of course, this approach won't work if someone names all their fields after known options, but I don't believe that will actually happen.