Skip to content

[Workflow] Fix test #53166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 21, 2023
Merged

[Workflow] Fix test #53166

merged 1 commit into from
Dec 21, 2023

Conversation

OskarStark
Copy link
Contributor

Q A
Branch? 5.4
Bug fix? no
New feature? no
Deprecations? no
Issues Follows #52402 (comment)
License MIT

@OskarStark OskarStark self-assigned this Dec 20, 2023
@carsonbot
Copy link

Hey!

To help keep things organized, we don't allow "Draft" pull requests. Could you please click the "ready for review" button or close this PR and open a new one when you are done?

Note that a pull request does not have to be "perfect" or "ready for merge" when you first open it. We just want it to be ready for a first review.

Cheers!

Carsonbot

@OskarStark OskarStark marked this pull request as ready for review December 20, 2023 23:37
@OskarStark OskarStark requested a review from lyrixx as a code owner December 20, 2023 23:37
@carsonbot carsonbot added this to the 5.4 milestone Dec 20, 2023
Nyholm
Nyholm approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree to move the excpectException() as far down as possible.

I also think the $this->addToAssertionCount(1); does not make any sense here.

@fabpot
Copy link
Member

fabpot commented Dec 21, 2023

Thank you @OskarStark.

@fabpot fabpot merged commit 100e5bc into symfony:5.4 Dec 21, 2023
@OskarStark OskarStark deleted the fix/test-workflow branch December 21, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyholm Nyholm Nyholm approved these changes

@xabbuh xabbuh xabbuh approved these changes

@lyrixx lyrixx Awaiting requested review from lyrixx lyrixx is a code owner

@nicolas-grekas nicolas-grekas Awaiting requested review from nicolas-grekas

Assignees

@OskarStark OskarStark

Labels
Status: Reviewed Workflow
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
5 participants
@OskarStark @carsonbot @fabpot @Nyholm @xabbuh