Skip to content

[Translation][Crowdin] Use project language mapping #53178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

andrii-bodnar
Copy link
Contributor

@andrii-bodnar andrii-bodnar commented Dec 21, 2023

Q A
Branch? 6.3
Bug fix? yes
New feature? no
Deprecations? no
Issues -
License MIT

Sometimes the locale codes may be different from the codes used in the Crowdin API. This will cause API errors because the wrong code is passed in the upload and download translation requests. There was already a fix (#50040), but it only works partially.

The suggested approach uses the language mapping configured in the Crowdin project. If the locale code and the crowdin code are different, the user needs to configure the language mapping in the Crowdin project.

Documentation - symfony/symfony-docs#19325

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "6.4" but it seems your PR description refers to branch "6.4, 7.0".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@andrii-bodnar andrii-bodnar force-pushed the fix/crowdin-language-mapping branch from 2fa3abe to d4f467c Compare December 21, 2023 18:02
@andrii-bodnar andrii-bodnar marked this pull request as draft December 22, 2023 07:31
@OskarStark OskarStark changed the title [Translation] Crowdin Bridge: use the project language mapping [Translation][Crowdin] Use project language mapping Dec 22, 2023
@andrii-bodnar andrii-bodnar marked this pull request as ready for review December 22, 2023 08:12
@nicolas-grekas nicolas-grekas modified the milestones: 6.4, 6.3 Dec 26, 2023
@nicolas-grekas
Copy link
Member

Thank you @andrii-bodnar.

@nicolas-grekas nicolas-grekas merged commit c529c4e into symfony:6.3 Dec 26, 2023
@andrii-bodnar andrii-bodnar deleted the fix/crowdin-language-mapping branch December 26, 2023 15:01
OskarStark added a commit to symfony/symfony-docs that referenced this pull request Dec 26, 2023
… (andrii-bodnar)

This PR was merged into the 6.3 branch.

Discussion
----------

[Translation] [Crowdin] Add a tip about language mapping

Related PR - symfony/symfony#53178

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/releases for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `6.x` for features of unreleased versions).

-->

Commits
-------

e9c44f4 [Translation] Add a tip about Crowdin language mapping
@andrii-bodnar
Copy link
Contributor Author

@pculka FYI. It may be necessary to set the language mapping in your project after the update.

@fabpot fabpot mentioned this pull request Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants