-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Translation][Crowdin] Use project language mapping #53178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nicolas-grekas
merged 1 commit into
symfony:6.3
from
andrii-bodnar:fix/crowdin-language-mapping
Dec 26, 2023
Merged
[Translation][Crowdin] Use project language mapping #53178
nicolas-grekas
merged 1 commit into
symfony:6.3
from
andrii-bodnar:fix/crowdin-language-mapping
Dec 26, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey! Thanks for your PR. You are targeting branch "6.4" but it seems your PR description refers to branch "6.4, 7.0". Cheers! Carsonbot |
2fa3abe
to
d4f467c
Compare
d4f467c
to
a1d2f67
Compare
Thank you @andrii-bodnar. |
OskarStark
added a commit
to symfony/symfony-docs
that referenced
this pull request
Dec 26, 2023
… (andrii-bodnar) This PR was merged into the 6.3 branch. Discussion ---------- [Translation] [Crowdin] Add a tip about language mapping Related PR - symfony/symfony#53178 <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/releases for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `6.x` for features of unreleased versions). --> Commits ------- e9c44f4 [Translation] Add a tip about Crowdin language mapping
@pculka FYI. It may be necessary to set the language mapping in your project after the update. |
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the locale codes may be different from the codes used in the Crowdin API. This will cause API errors because the wrong code is passed in the upload and download translation requests. There was already a fix (#50040), but it only works partially.
The suggested approach uses the language mapping configured in the Crowdin project. If the locale code and the crowdin code are different, the user needs to configure the language mapping in the Crowdin project.
Documentation - symfony/symfony-docs#19325