-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Intl] [Emoji] Fix emoji files (remove wrong characters / add missing data) #53203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey! Thanks for your PR. You are targeting branch "7.1" but it seems your PR description refers to branch "6.4". Cheers! Carsonbot |
How can i tell fabbot to not add Licence or correct typo in the generated files ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the reordering necessary? Can't we get rid of it? I'd prefer keeping the original order if possible.
By "original" you mean the one implemented previously ? The problem i see: it was not the same between locales (as soon as parent/child where involved), and a new child addind a translatation for a given emoji would change the message.. and its position in the array. |
I mean the order implemented previously yes, which is the order found in the source IIRC. |
The previous files were not ordered like the source ones, they were ordered by mb_strlen then source order.
And that order was kept only when no parent/child locale was involved |
I can mimic this behaviour to build the "model map" if you want |
I like reducing diffs so if you can then yes please :) |
Much better now indeed ... only the "child locales" have been updated As they were the only one concerned by the two problems (arrows instead of messages, and missing parent messages) this is much more logical. Thanks ;) |
Still don't know how to handle fabbot false positives ❓ |
ignoring them once they are checked 🧠 |
24cb85d
to
e9fcff5
Compare
Thank you @smnandre. |
Fix two things
↑↑↑
) instead of expected translationsAlso adapted the code to maintain a shared / reproductible order in the generated files.