Skip to content

[Mailer][Notifier] Simplify transport service registration + sorting #53222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 28, 2023
Merged

[Mailer][Notifier] Simplify transport service registration + sorting #53222

merged 1 commit into from
Dec 28, 2023

Conversation

OskarStark
Copy link
Contributor

Q A
Branch? 7.1
Bug fix? no
New feature? no
Deprecations? no
Issues -
License MIT

@carsonbot carsonbot added this to the 7.1 milestone Dec 26, 2023
@carsonbot carsonbot changed the title [Notifier][Mailer] Sort transports in tests [Mailer][Notifier] Sort transports in tests Dec 26, 2023
@OskarStark OskarStark changed the title [Mailer][Notifier] Sort transports in tests [Mailer][Notifier] Sort transports Dec 26, 2023
@OskarStark OskarStark requested a review from xabbuh December 26, 2023 22:05
@OskarStark
Copy link
Contributor Author

Are you ok with this PR @nicolas-grekas ?
If yes I will check mailer_transports.php too

@nicolas-grekas
Copy link
Member

Looks fine to me (but don't miss running tests)

@OskarStark OskarStark changed the title [Mailer][Notifier] Sort transports [Mailer][Notifier] Simplify transport service registration + sorting Dec 27, 2023
@OskarStark
Copy link
Contributor Author

but don't miss running tests

Done ✅

@fabpot
Copy link
Member

fabpot commented Dec 28, 2023

Thank you @OskarStark.

@fabpot fabpot merged commit 367be4b into symfony:7.1 Dec 28, 2023
@xabbuh xabbuh mentioned this pull request Jun 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@xabbuh xabbuh Awaiting requested review from xabbuh

+1 more reviewer

@alamirault alamirault alamirault approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Mailer Notifier Status: Reviewed
Projects
None yet
Milestone
7.1
Development

Successfully merging this pull request may close these issues.
5 participants
@OskarStark @nicolas-grekas @fabpot @alamirault @carsonbot